Add type hints for several pytorch models (batch-3) #25705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nablabits
commented
Aug 24, 2023
Comment on lines
+819
to
+820
| perturb: Optional[torch.FloatTensor] = None, | ||
| masked_tokens: None = None, |
There was a problem hiding this comment.
For perturb I took what microsoft/graphormer uses.
masked_tokens on the other hand, raises a NotImplemented whenever it has something that is not None
There was a problem hiding this comment.
Haa, that's funny. Congrats on our first correct type hint of an explicit None!
nablabits
commented
Aug 24, 2023
| input_ids: torch.LongTensor, | ||
| attention_mask: Optional[torch.FloatTensor] = None, | ||
| position_ids: Optional[torch.LongTensor] = None, | ||
| query_embeds: Optional[torch.Tensor] = None, |
There was a problem hiding this comment.
I was unsure of the dtype (I couldn't find any reference) so I left the generic torch.Tensor
nablabits
changed the title
Rocketknight1
approved these changes
Aug 25, 2023
Comment on lines
+819
to
+820
| perturb: Optional[torch.FloatTensor] = None, | ||
| masked_tokens: None = None, |
There was a problem hiding this comment.
Haa, that's funny. Congrats on our first correct type hint of an explicit None!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* Add missing type hints for ErnieM family * Add missing type hints for EsmForProteinFolding model * Add missing type hints for Graphormer model * Add type hints for InstructBlipQFormer model * Add missing type hints for LayoutLMForMaskedLM model * Add missing type hints for LukeForEntitySpanClassification model
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* Add missing type hints for ErnieM family * Add missing type hints for EsmForProteinFolding model * Add missing type hints for Graphormer model * Add type hints for InstructBlipQFormer model * Add missing type hints for LayoutLMForMaskedLM model * Add missing type hints for LukeForEntitySpanClassification model
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
* Add missing type hints for ErnieM family * Add missing type hints for EsmForProteinFolding model * Add missing type hints for Graphormer model * Add type hints for InstructBlipQFormer model * Add missing type hints for LayoutLMForMaskedLM model * Add missing type hints for LukeForEntitySpanClassification model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses some of the models in #16059:
ErnieMForInformationExtractionErnieMForMultipleChoiceErnieMForQuestionAnsweringErnieMForSequenceClassificationErnieMForTokenClassificationErnieMModelEsmForProteinFoldingGraphormerModelInstructBlipQFormerModelLayoutLMForMaskedLMLukeForEntitySpanClassificationWho can review?
@Rocketknight1, please