-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints for several pytorch models (batch-4) #25749
Merged
Rocketknight1
merged 10 commits into
huggingface:main
from
nablabits:feature/add-type-hints-for-models-batch-4
Aug 28, 2023
Merged
Add type hints for several pytorch models (batch-4) #25749
Rocketknight1
merged 10 commits into
huggingface:main
from
nablabits:feature/add-type-hints-for-models-batch-4
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nablabits
changed the title
Add type hints for several models models (batch-4)
Add type hints for several models (batch-4)
Aug 25, 2023
nablabits
changed the title
Add type hints for several models (batch-4)
Add type hints for several pytorch models (batch-4)
Aug 25, 2023
Rocketknight1
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! One quick type change, and one correction to the docstring - that bit wasn't your fault, but let's fix it while we're here.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Co-authored-by: Matt <[email protected]>
Co-authored-by: Matt <[email protected]>
…s-for-models-batch-4
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* Add type hints for MGP STR model * Add missing type hints for plbart model * Add type hints for Pix2struct model * Add missing type hints to Rag model and tweak the docstring * Add missing type hints to Sam model * Add missing type hints to Swin2sr model * Fix a type hint for Pix2StructTextModel Co-authored-by: Matt <[email protected]> * Fix typo on Rag model docstring Co-authored-by: Matt <[email protected]> * Fix linter --------- Co-authored-by: Matt <[email protected]>
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* Add type hints for MGP STR model * Add missing type hints for plbart model * Add type hints for Pix2struct model * Add missing type hints to Rag model and tweak the docstring * Add missing type hints to Sam model * Add missing type hints to Swin2sr model * Fix a type hint for Pix2StructTextModel Co-authored-by: Matt <[email protected]> * Fix typo on Rag model docstring Co-authored-by: Matt <[email protected]> * Fix linter --------- Co-authored-by: Matt <[email protected]>
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
* Add type hints for MGP STR model * Add missing type hints for plbart model * Add type hints for Pix2struct model * Add missing type hints to Rag model and tweak the docstring * Add missing type hints to Sam model * Add missing type hints to Swin2sr model * Fix a type hint for Pix2StructTextModel Co-authored-by: Matt <[email protected]> * Fix typo on Rag model docstring Co-authored-by: Matt <[email protected]> * Fix linter --------- Co-authored-by: Matt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses some of the models in #16059:
MgpstrForSceneTextRecognition
MgpstrModel
PLBartForConditionalGeneration
PLBartModel
Pix2StructTextModel
RagModel
SamModel
Swin2SRModel
Who can review?
@Rocketknight1, please