🌐 [i18n-KO] `model_memory_anatomy.md` to Korean #25755

mjk0618 · 2023-08-25T12:19:07Z

What does this PR do?

Translated the model_memory_anatomy.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

Check for missing / redundant translations (번역 누락/중복 검사)
Grammar Check (맞춤법 검사)
Review or Add new terms to glossary (용어 확인 및 추가)
Check Inline TOC (e.g. [[lowercased-header]])
Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@bolizabeth, @nuatmochoi, @heuristicwave, @mjk0618, @keonju2, @harheem, @HongB1, @junejae, @54data, @seank021, @augustinLib, @sronger, @TaeYupNoh, @kj021, @eenzeenee

Before submitting

This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
Did you read the contributor guideline,
Pull Request section?
Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
Did you write any new necessary tests?

Who can review? (Final)

May you please review this PR? @sgugger, @ArthurZucker, @eunseojo

stevhliu

Thanks for the translation! Can you update your branch with the latest changes on main? I think that should fix the Build PR Documentation test :)

HuggingFaceDocBuilderDev · 2023-08-28T13:45:35Z

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

docs/source/ko/model_memory_anatomy.md

heuristicwave

@mjk0618 님 리뷰 완료했습니다!

docs/source/ko/model_memory_anatomy.md

Co-authored-by: SeongWooChoi <[email protected]>

Co-authored-by: heuristicwave <[email protected]>

sim-so

이번 문서 번역하시느라 무척 고생 많으셨습니다! 문장마다 고민하신 흔적이 느껴집니다 🥲

서식이나 단어 사용에 틀린 부분이 거의 없어서 한국어 표현을 중심으로 리뷰를 해보았습니다.
대부분 제 개인적인 의견으로 작성된 내용이오니 편히 생각하시고 원하시는 만큼 반영해주셔도 괜찮습니다!
제안 사항에 대해 의견이나 질문을 보내주셔도 좋습니다! 항상 감사합니다 😊

docs/source/ko/model_memory_anatomy.md

Co-authored-by: Sohyun Sim <[email protected]>

mjk0618 · 2023-08-29T11:17:55Z

May you please review this PR? @sgugger, @ArthurZucker, @eunseojo

ArthurZucker

LGTM! cc @stevhliu for a second look

stevhliu

Great job, thanks for the translation! 🤗

* docs: ko-model_memory_anatomy.md * feat: chatgpt draft * feat: manual edits * feat: change document title * feat: manual edits * fix: resolve suggestion Co-authored-by: SeongWooChoi <[email protected]> * fix: resolve suggestion Co-authored-by: SeongWooChoi <[email protected]> * fix: resolve suggestion Co-authored-by: SeongWooChoi <[email protected]> * fix: resolve suggestion Co-authored-by: SeongWooChoi <[email protected]> * fix: resolve suggestion Co-authored-by: SeongWooChoi <[email protected]> * fix: resolve suggestion Co-authored-by: heuristicwave <[email protected]> * fix: resolve suggestion Co-authored-by: heuristicwave <[email protected]> * fix: resolve suggestion Co-authored-by: Sohyun Sim <[email protected]> * fix: resolve suggestion Co-authored-by: Sohyun Sim <[email protected]> * fix: resolve suggestion Co-authored-by: Sohyun Sim <[email protected]> * fix: resolve suggestion Co-authored-by: Sohyun Sim <[email protected]> * fix: resolve suggestion Co-authored-by: Sohyun Sim <[email protected]> * fix: resolve suggestion Co-authored-by: Sohyun Sim <[email protected]> * fix: resolve suggestion Co-authored-by: Sohyun Sim <[email protected]> * fix: resolve suggestion --------- Co-authored-by: SeongWooChoi <[email protected]> Co-authored-by: heuristicwave <[email protected]> Co-authored-by: Sohyun Sim <[email protected]>

mjk0618 added 4 commits August 25, 2023 04:31

docs: ko-model_memory_anatomy.md

a289b38

feat: chatgpt draft

ccc82fc

feat: manual edits

dbbf28e

feat: change document title

7fb22f0

mjk0618 marked this pull request as ready for review August 25, 2023 12:34

mjk0618 marked this pull request as draft August 25, 2023 12:47

stevhliu mentioned this pull request Aug 25, 2023

🌐 [i18n-KO] Translating docs to Korean #20179

Open

84 tasks

stevhliu reviewed Aug 25, 2023

View reviewed changes

mjk0618 and others added 3 commits August 27, 2023 00:20

Merge branch 'huggingface:main' into ko-model_memory_anatomy

15d7d00

Merge branch 'huggingface:main' into ko-model_memory_anatomy

eb8291c

feat: manual edits

ec6d395

nuatmochoi suggested changes Aug 28, 2023

View reviewed changes

heuristicwave reviewed Aug 29, 2023

View reviewed changes

docs/source/ko/model_memory_anatomy.md Outdated Show resolved Hide resolved

docs/source/ko/model_memory_anatomy.md Outdated Show resolved Hide resolved

mjk0618 and others added 8 commits August 29, 2023 16:15

fix: resolve suggestion

653ca78

Co-authored-by: SeongWooChoi <[email protected]>

fix: resolve suggestion

bd8c574

Co-authored-by: SeongWooChoi <[email protected]>

fix: resolve suggestion

8384da2

Co-authored-by: SeongWooChoi <[email protected]>

fix: resolve suggestion

50d8324

Co-authored-by: SeongWooChoi <[email protected]>

fix: resolve suggestion

8d30013

Co-authored-by: SeongWooChoi <[email protected]>

fix: resolve suggestion

849893a

Co-authored-by: heuristicwave <[email protected]>

fix: resolve suggestion

18ff370

Co-authored-by: heuristicwave <[email protected]>

Merge branch 'huggingface:main' into ko-model_memory_anatomy

4dba741

sim-so suggested changes Aug 29, 2023

View reviewed changes

mjk0618 and others added 7 commits August 29, 2023 16:38

fix: resolve suggestion

712bf2c

Co-authored-by: Sohyun Sim <[email protected]>

fix: resolve suggestion

722b951

Co-authored-by: Sohyun Sim <[email protected]>

fix: resolve suggestion

bff9159

Co-authored-by: Sohyun Sim <[email protected]>

fix: resolve suggestion

ad9204d

Co-authored-by: Sohyun Sim <[email protected]>

fix: resolve suggestion

d0f64d2

Co-authored-by: Sohyun Sim <[email protected]>

fix: resolve suggestion

aba804d

Co-authored-by: Sohyun Sim <[email protected]>

fix: resolve suggestion

82186db

Co-authored-by: Sohyun Sim <[email protected]>

fix: resolve suggestion

d4c28fd

mjk0618 marked this pull request as ready for review August 29, 2023 10:39

ArthurZucker approved these changes Aug 29, 2023

View reviewed changes

stevhliu approved these changes Aug 29, 2023

View reviewed changes

stevhliu merged commit 33aa0af into huggingface:main Aug 29, 2023
3 checks passed

stevhliu mentioned this pull request Aug 29, 2023

Ko perf train gpu one #25250

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌐 [i18n-KO] `model_memory_anatomy.md` to Korean #25755

🌐 [i18n-KO] `model_memory_anatomy.md` to Korean #25755

mjk0618 commented Aug 25, 2023 •

edited

Loading

stevhliu left a comment

HuggingFaceDocBuilderDev commented Aug 28, 2023

heuristicwave left a comment

sim-so left a comment

mjk0618 commented Aug 29, 2023

ArthurZucker left a comment

stevhliu left a comment

🌐 [i18n-KO] model_memory_anatomy.md to Korean #25755

🌐 [i18n-KO] model_memory_anatomy.md to Korean #25755

Conversation

mjk0618 commented Aug 25, 2023 • edited Loading

What does this PR do?

Before reviewing

Who can review? (Initial)

Before submitting

Who can review? (Final)

stevhliu left a comment

Choose a reason for hiding this comment

HuggingFaceDocBuilderDev commented Aug 28, 2023

heuristicwave left a comment

Choose a reason for hiding this comment

sim-so left a comment

Choose a reason for hiding this comment

mjk0618 commented Aug 29, 2023

ArthurZucker left a comment

Choose a reason for hiding this comment

stevhliu left a comment

Choose a reason for hiding this comment

🌐 [i18n-KO] `model_memory_anatomy.md` to Korean #25755

🌐 [i18n-KO] `model_memory_anatomy.md` to Korean #25755

mjk0618 commented Aug 25, 2023 •

edited

Loading