[idefics] fix vision's hidden_act
#25787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
rwightman
approved these changes
Aug 27, 2023
rwightman
approved these changes
Aug 27, 2023
ArthurZucker
approved these changes
Aug 28, 2023
Narsil
pushed a commit
to huggingface/text-generation-inference
that referenced
this pull request
Sep 1, 2023
transposing the fixes from huggingface/transformers#25787
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
[idefics] fix vision's hidden_act
verdant621
pushed a commit
to verdant621/text-generation-inference
that referenced
this pull request
Oct 19, 2023
transposing the fixes from huggingface/transformers#25787
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
[idefics] fix vision's hidden_act
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
[idefics] fix vision's hidden_act
cr313
added a commit
to cr313/text-generation-inference-load-test
that referenced
this pull request
Apr 19, 2024
transposing the fixes from huggingface/transformers#25787
alfredgui2
pushed a commit
to mlsys-io/kv.run
that referenced
this pull request
Jul 6, 2024
transposing the fixes from huggingface/transformers#25787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @rwightman's discovery this PR is fixing vision config's
hidden_acttogelu.It looks like we messed things up when splitting the original config into 3 groups during the porting and inherited
clip's default config. Whereas the model used during training was usinggeluas can be seen here. https://huggingface.co/laion/CLIP-ViT-H-14-laion2B-s32B-b79K/blob/main/config.jsonThank you, @rwightman