Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VITS] tokenizer integration test: fix revision did not exist #25996

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

ArthurZucker
Copy link
Collaborator

@ArthurZucker ArthurZucker commented Sep 5, 2023

What does this PR do?

Fixes the revisiono f the integration test for the VITs tokenizer.
RUN_SLOW=1 pytest tests/models/vits/test_tokenization_vits.py on main outputs:

E           OSError: Can't load tokenizer for 'facebook/mms-tts-eng'. If you were trying to load it from 'https://huggingface.co/models', make sure you don't have a local directory with the same name. Otherwise, make sure 'facebook/mms-tts-eng' is the correct path to a directory containing all relevant files for a VitsTokenizer tokenizer.

src/transformers/tokenization_utils_base.py:1893: OSError

because the revision does not exist

@@ -174,7 +174,7 @@ def test_tokenizer_integration(self):
for tokenizer_class in tokenizer_classes:
tokenizer = tokenizer_class.from_pretrained(
"facebook/mms-tts-eng",
revision="d188a254c84ae6cfd24deb7a8f5c0c1d349d7d9f", # to pin the tokenizer version
revision="089bbb15da46b2ab2b282145941399aae353d917", # to pin the tokenizer version
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pad token changed from k to <pad>

@ArthurZucker ArthurZucker changed the title revision did not exist [VITS] tokenizer integration test: fix revision did not exist Sep 5, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 5, 2023

The documentation is not available anymore as the PR was closed or merged.

@ArthurZucker ArthurZucker merged commit 4fa0aff into huggingface:main Sep 5, 2023
3 checks passed
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants