Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate peft.md to chinese #27215

Merged
merged 4 commits into from
Nov 2, 2023
Merged

translate peft.md to chinese #27215

merged 4 commits into from
Nov 2, 2023

Conversation

jiaqiw09
Copy link
Contributor

@jiaqiw09 jiaqiw09 commented Nov 1, 2023

What does this PR do?

Part of #26803

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests? not necessary

Who can review?

@stevhliu

@jiaqiw09
Copy link
Contributor Author

jiaqiw09 commented Nov 1, 2023

@stevhliu

hi, here is another pr for peft.md translation.

And I just check the _toctree.yml file, and I think I will first finish section Tutorials and Developer guides. I think it may be helpful for people who want to try transformers. Then I will continue to work on anther sections. When we finsihed all translation work with other contributors, I think it's better to look back and update some link info, small typos or wrong translation words.

Just try to do some work by the end of this year. Many people is using transformers as it's the trend for DL work, it's better to give more detailed docs with variety language. And I think more people will do contribution when they can get enough help from amounts of translated docs.

Best

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another translation!

I fully agree with your plan, and feel free to continue to ping me for any reviews or if I can help you with anything else 🤗

docs/source/zh/peft.md Outdated Show resolved Hide resolved
docs/source/zh/peft.md Outdated Show resolved Hide resolved
@jiaqiw09
Copy link
Contributor Author

jiaqiw09 commented Nov 2, 2023

@stevhliu

Hi, I have fixed problems.

And for <br>, I just think it is too compact to read easily. But I still delete this line.

Best

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation!

@stevhliu stevhliu merged commit 00d8502 into huggingface:main Nov 2, 2023
8 checks passed
@jiaqiw09 jiaqiw09 deleted the peft branch November 6, 2023 04:46
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
* tranlsate peft.md to chinese

* translate peft.md to chinese

* fix missing link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants