-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate: skip tests on unsupported models instead of passing #27265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! ❤️
The documentation is not available anymore as the PR was closed or merged. |
if any(model_name in model_class.__name__.lower() for model_name in ["umt5"]): | ||
return | ||
self.skipTest("TODO: needs modeling or test input preparation fixes for compatibility") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is better, but as we are in for model_class in self.all_generative_model_classes
, it probably means we skip many model_class
unnecessary if a previous one is skipped here.
Good to merge. I can do a follow up PR to use subTest
(as an exercise for me)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a second look, subTest doesn't make much sense here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
What does this PR do?
Skip tests on unsupported models instead of passing, as discussed in #25086
NOTE: I've skipped to whole test in the loop over different heads as soon as it encountered a problem because a) the reason for the skips in generate is always due to some core property of the architecture (AFAIK) b) simplicity