Fix Kosmos2Processor batch mode
#27323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Nov 6, 2023
| @@ -211,7 +211,9 @@ def __call__( | |||
| image_embeds_position_mask.append(mask) | |||
|
|
|||
| if isinstance(text, list): | |||
| sorted_length = sorted([(idx, len(x)) for idx, x in enumerate(text_encoding.input_ids)]) | |||
| sorted_length = sorted( | |||
| [(idx, len(x)) for idx, x in enumerate(text_encoding.input_ids)], key=lambda x: x[-1] | |||
There was a problem hiding this comment.
Here my intention was to sort with the length, not the index. However, I forgot to specify the key so it did not do what I expected.
There was a problem hiding this comment.
Note that we do have tests regarding the batch mode - but the examples I used have the longest sequence as the last example in a batch, so it didn't detect this issue 😭
There was a problem hiding this comment.
Can we update the test so that it would have been caught?
|
All tests (even slow) pass! |
4 tasks
amyeroberts
approved these changes
Nov 6, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* fix * fix * fix --------- Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
Kosmos2Processorbatch mode as there is a bug, see comment in the code change.Fix one issue about batch mode opened in #27301