Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated torch.range in tests/models/ibert/test_modeling_ibert.py #27355

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

kit1980
Copy link
Contributor

@kit1980 kit1980 commented Nov 8, 2023

What does this PR do?

torch.range is deprecated since PyTorch 0.4 and will be removed in a future PyTorch release.
This PR updates it to torch.arange.
Fixed with TorchFix https://github.com/pytorch/test-infra/tree/main/tools/torchfix

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

cc @ydshieh

@kit1980 kit1980 marked this pull request as ready for review November 8, 2023 01:58
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for this ❤️ @kit1980 .

Could you remove # x_int = torch.range(-10000, 10000, 1) in the same file?
~line 568

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@kit1980
Copy link
Contributor Author

kit1980 commented Nov 8, 2023

@ydshieh I've removed the commented out line.

@ydshieh ydshieh merged commit 0e402e1 into huggingface:main Nov 8, 2023
18 checks passed
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
…ace#27355)

* Update deprecated torch.range

* Remove comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants