Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Flash Attention 2 support to Bark #27364

Merged
merged 12 commits into from
Nov 8, 2023
Merged

Add Flash Attention 2 support to Bark #27364

merged 12 commits into from
Nov 8, 2023

Commits on Nov 8, 2023

  1. change handmade attention mask to _prepare_4d_attention_mask

    @ylacombe
    ylacombe committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    0eadfab View commit details
    Browse the repository at this point in the history

  2. add flashattention2 support in Bark

    @ylacombe
    ylacombe committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    0fcff47 View commit details
    Browse the repository at this point in the history

  3. add flashattention2 tests on BarkSemanticModel

    @ylacombe
    ylacombe committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    7ca710c View commit details
    Browse the repository at this point in the history

  4. make style

    @ylacombe
    ylacombe committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    10d81ba View commit details
    Browse the repository at this point in the history

  5. fix flashattention and tests + make style

    @ylacombe
    ylacombe committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    32fb57d View commit details
    Browse the repository at this point in the history

  6. fix memory leak and allow Bark to pass flash attention to sub-models

    @ylacombe
    ylacombe committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c2ff5f4 View commit details
    Browse the repository at this point in the history

  7. make style

    @ylacombe
    ylacombe committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    ef106a4 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Sanchit Gandhi <[email protected]>
    @ylacombe @sanchit-gandhi
    ylacombe and sanchit-gandhi authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    425d41d View commit details
    Browse the repository at this point in the history

  9. remove unecessary code from tests + justify overriding

    @ylacombe
    ylacombe committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    049c2e9 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'bark-flashattention-2' of github.com:ylacombe/transform… 

    …ers into bark-flashattention-2
    @ylacombe
    ylacombe committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c6a34cf View commit details
    Browse the repository at this point in the history

  11. Update tests/models/bark/test_modeling_bark.py 

    Co-authored-by: amyeroberts <[email protected]>
    @ylacombe @amyeroberts
    ylacombe and amyeroberts authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    653fa13 View commit details
    Browse the repository at this point in the history

  12. make style

    @ylacombe
    ylacombe committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    5f76f13 View commit details
    Browse the repository at this point in the history