Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version check for Jinja #27403

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Add version check for Jinja #27403

merged 3 commits into from
Nov 13, 2023

Conversation

Rocketknight1
Copy link
Member

As @philschmid noticed, apply_chat_template requires jinja version 3.x, but it's possible for some users to still have 2.x installed. We now raise a useful error in this case.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 9, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@Rocketknight1 Rocketknight1 merged commit 1af766e into main Nov 13, 2023
21 checks passed
@Rocketknight1 Rocketknight1 deleted the jinja_version_check branch November 13, 2023 17:01
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
* Add version check for Jinja

* Update src/transformers/tokenization_utils_base.py

Co-authored-by: amyeroberts <[email protected]>

* make fixup

---------

Co-authored-by: amyeroberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants