Generate: fix ExponentialDecayLengthPenalty doctest
#27485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
approved these changes
Nov 14, 2023
|
The failing test is known on doctest CI, so good for me to merge. I already ping @sanchit-gandhi on slack. |
|
@amyeroberts would you be able to merge this PR, as the failure is unrelated? (different doctest on the same file) :) |
|
I can do it, but maybe wait @amyeroberts this time (so she knows I can 😄 without surprise) |
|
I can merge! cc @sanchit-gandhi as the failing doctest is a whisper one. |
Saibo-creator
pushed a commit
to epfl-dlab/transformers-GCD-PR
that referenced
this pull request
Nov 15, 2023
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The doctest was failing... but the root cause for the failure in
transformers.generation.logits_process.ExponentialDecayLengthPenaltyis the transition fromtorch==2.0totorch==2.1(i.e. installingtorch==2.0fixes it).I couldn’t find any related reference in the release notes, but I know they touched
torch.multinomialafter the 2.0 release -- it was sampling things with probability=0.0. This change may impact this doctest, as it is sample-based and it may induce probabilities=0.0.As such, the fix consists of updating the test's outputs. I took the opportunity to improve the example as well :)