-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: replace torch.distributed.run by torchrun #27528
Conversation
I just found an old PR which did the similar work https://github.com/huggingface/transformers/pull/21780/files but out of sync. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
Just a few comments on removing the changes for the research examples.
For any future readers who stumble on this PR: the previously closed PR requested comments in the docs for older pytorch versions. We now officially support pytorch >= 1.10. The entrypoint torchrun
is present from 1.10 onwards.
examples/research_projects/self-training-text-classification/README.md
Outdated
Show resolved
Hide resolved
examples/research_projects/seq2seq-distillation/precomputed_pseudo_labels.md
Outdated
Show resolved
Hide resolved
`transformers` now officially support pytorch >= 1.10. The entrypoint `torchrun`` is present from 1.10 onwards. Signed-off-by: Peter Pan <[email protected]>
comments already addressed, now PR can be merged now. |
with @ArthurZucker's suggestion Co-authored-by: Arthur <[email protected]>
What does this PR do?
The old way will be deprecated , move to new torchrun.
FutureWarning: The module torch.distributed.launch is deprecated and will be removed in future. Use torchrun.
This PR only addresses the doc part, not touching the unit-test to limit the impact.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.