Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix 404 link #27529

Merged
merged 1 commit into from
Nov 20, 2023
Merged

docs: fix 404 link #27529

merged 1 commit into from
Nov 20, 2023

Conversation

panpan0000
Copy link
Contributor

@panpan0000 panpan0000 commented Nov 16, 2023

What does this PR do?

ISSUE:
when you go to doc : https://huggingface.co/docs/transformers/main/en/main_classes/trainer#specific-gpus-selection
image

the link is 404 due to URL is case sentitive.
image

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@panpan0000
Copy link
Contributor Author

panpan0000 commented Nov 17, 2023

@amyeroberts , Many thanks to your kindly review and help.

But the check was unsuccessful and I was lost.
image

detail log as below
image
but even I ran make quality on main head 06343b0 , it failed

Oh no! 💥 💔 💥
3 files would be reformatted, 2678 files would be left unchanged.

or run on my PR with command doc-builder style src/transformers docs/source --max_len 119 --check_only --path_to_docs docs/source, it was succesful.

Signed-off-by: Peter Pan <[email protected]>
@amyeroberts
Copy link
Collaborator

@panpan0000 Unfortunately we had some package dependency nightmares this week. The fix was pushed to main - I can see you've rebased to get the updates and it's all working now ❤️

Thank you for your patience and for looking into the issue. Once the final build PR documentation run has finished we can merge :)

@panpan0000
Copy link
Contributor Author

awesome @amyeroberts , nice community here!

@amyeroberts amyeroberts merged commit e4280d6 into huggingface:main Nov 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants