Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AMD CI not showing GPU #27555

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix AMD CI not showing GPU #27555

merged 1 commit into from
Nov 17, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Nov 17, 2023

What does this PR do?

For AMD CI jobs, like this one, in the Environment section, sometimes it shows Number of GPUs available: 0.

After investigation from the infra team (thanks to Guillaume), they told me the changes in this PR fix the issue: removing the environment variable HIP_VISIBLE_DEVICES.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@amyeroberts
Copy link
Collaborator

After merging are we able to reenable the tests from #27541 ?

@ydshieh
Copy link
Collaborator Author

ydshieh commented Nov 17, 2023

After merging are we able to reenable the tests from #27541 ?

No, these 2 are irrelevant. #27541 is about AMD docker image can't be built while this one is some issue at testing time (even if we build the image manually)

@ydshieh ydshieh merged commit d903abf into main Nov 17, 2023
8 checks passed
@ydshieh ydshieh deleted the fix_rocm_gpu_issue branch November 17, 2023 09:44
wgifford pushed a commit to namctin/transformers that referenced this pull request Nov 17, 2023
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants