Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect RoCm support in the documentation #27636

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Nov 21, 2023

As per title.

We will need huggingface/optimum#1546 to be merged first, and an Optimum release.

@fxmarty
Copy link
Contributor Author

fxmarty commented Nov 21, 2023

We may want to update https://huggingface.co/docs/transformers/perf_hardware as well, explaining rocm-smi --showtopoweight and rocm-smi --shownodesbw output.

@fxmarty
Copy link
Contributor Author

fxmarty commented Nov 24, 2023

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

docs/source/en/main_classes/trainer.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, maybe a special section for # AMD support would make it more visible as well ?

docs/source/en/perf_infer_gpu_one.md Outdated Show resolved Hide resolved
docs/source/en/perf_infer_gpu_one.md Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 24, 2023

The documentation is not available anymore as the PR was closed or merged.

@fxmarty
Copy link
Contributor Author

fxmarty commented Nov 24, 2023

Thanks @ArthurZucker that would indeed be a great addition showcasing the variety of hardware supported by Transformers (or extensions of transformers / other community libraries). I'll leave it for an other PR!

@fxmarty fxmarty merged commit c13a43a into huggingface:main Nov 24, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants