Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translating en/model_doc folder docs to Japanese(from blip to clap) 🇯🇵 #27673

Merged
merged 16 commits into from
Dec 6, 2023
Merged

Translating en/model_doc folder docs to Japanese(from blip to clap) 🇯🇵 #27673

merged 16 commits into from
Dec 6, 2023

Conversation

rajveer43
Copy link
Contributor

What does this PR do?

Fixes #27669

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Documentation: @stevhliu and @MKhalusova

stevhliu
stevhliu reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting translations on the next batch of models!

docs/source/ja/model_doc/blip-2.md Show resolved Hide resolved
docs/source/ja/model_doc/blip-2.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/bort.md Show resolved Hide resolved
docs/source/ja/model_doc/bros.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/bros.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/camembert.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/canine.md Outdated

CANINE モデルは、[CANINE: 言語用の効率的なトークン化フリーのエンコーダーの事前トレーニング](https://arxiv.org/abs/2103.06874)、Jonathan H. Clark、Dan Garrette、Iulia Turc、John Wieting 著。その
明示的なトークン化ステップ (バイト ペアなど) を使用せずに Transformer をトレーニングする最初の論文の 1 つ
エンコーディング (BPE)、WordPiece または SentencePiece)。代わりに、モデルは Unicode 文字レベルで直接トレーニングされます。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the opening ( here for BPE, WordPiece and SentencePiece

docs/source/ja/model_doc/chinese_clip.md Outdated

## Overview

Chinese-CLIP モデルは、An Yang、Junshu Pan、Junyang Lin、Rui Men、Yichang Zhang、Jingren によって [中国語 CLIP: Contrastive Vision-Language Pretraining in Chinese](https://arxiv.org/abs/2211.01335) で提案されました。周、張周。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an author here

docs/source/ja/model_doc/chinese_clip.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/byt5.md Outdated

## Overview

ByT5 モデルは、[ByT5: 事前トレーニングされたバイト間モデルによるトークンフリーの未来へ](https://arxiv.org/abs/2105.13626) で、Linting Xue、Aditya Barua、Noah Constant、Rami によって提示されました。アル・ルフォウ、シャラン・ナラン、ミヒル
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed in some of the translations, you don't translate the paper title and in others it is translated. I think for consistency, let's keep the paper titles untranslated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

@rajveer43 rajveer43 mentioned this pull request Nov 30, 2023
Closed
10 tasks
stevhliu
stevhliu reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more accidentally translated things, but otherwise should be good to go after they're fixed

docs/source/ja/model_doc/chinese_clip.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/canine.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/bros.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/bridgetower.md Outdated Show resolved Hide resolved
stevhliu
stevhliu approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you try running make fixup and pip uninstall black && pip install -U ruff==0.1.5 to fix the failing CI test?

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@rajveer43
Copy link
Contributor Author

LGTM! Can you try running make fixup and pip uninstall black && pip install -U ruff==0.1.5 to fix the failing CI test?

sure.

@stevhliu stevhliu merged commit 9660e27 into huggingface:main Dec 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevhliu stevhliu Awaiting requested review from stevhliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[i18n-jp] Translating en/model_doc folder docs to Japanese 🇯🇵
3 participants
@rajveer43 @HuggingFaceDocBuilderDev @stevhliu