Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce pin memory disabling when using cpu only #27745

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Nov 28, 2023

What does this PR do?

Fixes #26556

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@muellerzr

I would skip writing new test, it's really hard to test, plus it's a minor fix

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ArthurZucker tl;dr summary for you: if use_cpu is used the dataloaders will still use CUDA if available/reserve it in some cases for certain things. pin_memory is a GPU-only capability anyways, so it doesn't matter if the user wants to use their CPU only

@qgallouedec qgallouedec changed the title Fix training failure when GPU memory saturated and --use_cpu Enforce pin memory disabling when using cpu only Nov 28, 2023
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both, makes sense

@ArthurZucker ArthurZucker merged commit 0b9c934 into huggingface:main Nov 28, 2023
21 checks passed
@qgallouedec qgallouedec deleted the fix-use-cpu-pin-memory branch November 29, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Training failure with --use_cpu option when GPU memory is saturated
4 participants