Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update create_model_card to properly save peft details when using Trainer with PEFT #27754

Merged
merged 3 commits into from
Dec 7, 2023
Merged

update create_model_card to properly save peft details when using Trainer with PEFT #27754

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9763755
update `create_model_card` to properly save peft details when using T…
pacman100 Nov 28, 2023
3e54b4a
nit
pacman100 Nov 28, 2023
1e4985e
Apply suggestions from code review
pacman100 Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/transformers/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
import numpy as np
import torch
import torch.distributed as dist
from huggingface_hub import create_repo, upload_folder
from huggingface_hub import ModelCard, create_repo, upload_folder
from packaging import version
from torch import nn
from torch.utils.data import DataLoader, Dataset, RandomSampler, SequentialSampler
Expand Down Expand Up @@ -3489,6 +3489,12 @@ def create_model_card(
if not self.is_world_process_zero():
return

model_card_filepath = os.path.join(self.args.output_dir, "README.md")
is_peft_library = False
if os.path.exists(model_card_filepath):
library_name = ModelCard.load(model_card_filepath).data.get("library_name")
is_peft_library = library_name == "peft"

training_summary = TrainingSummary.from_trainer(
self,
language=language,
Expand All @@ -3502,9 +3508,12 @@ def create_model_card(
dataset_args=dataset_args,
)
model_card = training_summary.to_model_card()
with open(os.path.join(self.args.output_dir, "README.md"), "w") as f:
with open(model_card_filepath, "w") as f:
f.write(model_card)

if is_peft_library:
unwrap_model(self.model).create_or_update_model_card(self.args.output_dir)

def _push_from_checkpoint(self, checkpoint_folder):
# Only push from one node.
if not self.is_world_process_zero() or self.args.hub_strategy == HubStrategy.END:
Expand Down
Loading