Fix typo in max_length deprecation warnings

[siegeln]

What does this PR do?

Specifying the max_length parameter in some text generation functions results in a deprecation warning. Currently, these warnings say to fix by using stopping_criteria=StoppingCriteriaList(MaxLengthCriteria(max_length=max_length)); however, this results in the error TypeError: 'MaxLengthCriteria' object is not iterable, as StoppingCriteriaList expects an iterable.

This PR fixes this typo.

Before submitting

• This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
• Did you read the contributor guideline,
  Pull Request section?
• Was this discussed/approved via a Github issue or the forum? Please add a link
  to it if that's the case.
• Did you make sure to update the documentation with your changes? Here are the
  documentation guidelines, and
  here are tips on formatting docstrings.
• Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

[ArthurZucker]

Thanks! cc @gante pretty sure we can remove the warning no? max_length is as convenient as max_new_tokens IMO? 😉

[gante]

Thank you for the fix!

[gante]

@ArthurZucker in this case they are not interchangeable, MaxLengthCriteria expects max_length. In generate, max_new_tokens is converted into its max_length equivalent before MaxLengthCriteria is initialized :)

[ArthurZucker]

Ah right! Missed that, thanks 😉

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.