Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update warning text, a word was missing #28017

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

tomaarsen
Copy link
Member

Hello!

What does this PR do?

  • Updates a warning text: "lead" was missing.

I missed this in the original PR, apologies.

Before submitting

  • This PR fixes a typo or improves the docs

Who can review?

@ArthurZucker

cc: @stas00 Thanks for pointing this out here: #26681 (comment)

  • Tom Aarsen

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@huggingface huggingface deleted a comment from github-actions bot Jan 14, 2024
@tomaarsen
Copy link
Member Author

@amyeroberts This should be a simple merge; but I'd like to leave it to a core maintainer as I'm not 100% sure whether non-core maintainers should be merging on transformers.

@ArthurZucker
Copy link
Collaborator

ArthurZucker commented Jan 15, 2024

We usually let HF people merge their own PRs 😉 Could you rebase on main before merging?

@tomaarsen
Copy link
Member Author

Good to know!

Rebased & force pushed :)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@tomaarsen tomaarsen merged commit 881e966 into huggingface:main Jan 15, 2024
19 checks passed
@tomaarsen tomaarsen deleted the chore/update_warning branch January 15, 2024 09:08
staghado pushed a commit to staghado/transformers that referenced this pull request Jan 15, 2024
MadElf1337 pushed a commit to MadElf1337/transformers that referenced this pull request Jan 15, 2024
wgifford pushed a commit to wgifford/transformers that referenced this pull request Jan 21, 2024
AjayP13 pushed a commit to AjayP13/transformers that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants