More TF fixes #28081
Merged
More TF fixes #28081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick re-ping about this one @amyeroberts! (it's a very small PR, but I'd like to get it in so the CI stops upsetting Yih-Dar) |
amyeroberts
approved these changes
Dec 18, 2023
staghado
pushed a commit
to staghado/transformers
that referenced
this pull request
Jan 15, 2024
* More build_in_name_scope() * Make sure we set the save spec now we don't do it with dummies anymore * make fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TF
build()PR brought back an old issue where TF would latch onto the first concrete shape it saw, which would then become the model's save signature. We avoid it by hittingself._set_save_spec()with flexible shapes ASAP when models are created.This PR also replaces a few more instances of
build()withbuild_in_name_scope()in our tests. This should hopefully fix the CI issues (cc @ydshieh)