Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _speculative_sampling implementation #28508

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Fix _speculative_sampling implementation #28508

merged 7 commits into from
Jan 19, 2024

Commits on Jan 15, 2024

  1. Fix _speculative_sampling implementation

    @ofirzaf
    ofirzaf committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    0c5a146 View commit details
    Browse the repository at this point in the history

  2. Fix wrong clamping in rejection sampling

    @ofirzaf
    ofirzaf committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    d5224cf View commit details
    Browse the repository at this point in the history

  3. Improve readability of _speculative_sampling

    @ofirzaf
    ofirzaf committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    2725e16 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. @ofirzaf 

    Fix candidate generation more than max_length - 1
    @ofirzaf
    ofirzaf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    190a63a View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Clarify speculative behavior on acceptance of EOS

    @ofirzaf
    ofirzaf committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    48b2685 View commit details
    Browse the repository at this point in the history

  2. Avert candidate generation if max_new_tokens == 0

    @ofirzaf
    ofirzaf committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    3b9e406 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Add test for _speculative_sampling

    @ofirzaf
    ofirzaf committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    a55181f View commit details
    Browse the repository at this point in the history