Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve _update_causal_mask performance #29210

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

alessandropalla
Copy link
Contributor

@alessandropalla alessandropalla commented Feb 22, 2024

What does this PR do?

Fixes # (issue)
#29206

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is there other changes you need to put in?

@alessandropalla
Copy link
Contributor Author

@ArthurZucker I think it can be merged, if I found additional optimizations I'll add them into another PR

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you run the slow tests for both models? (otherwise I'll spin an instance and do it)

@alessandropalla
Copy link
Contributor Author

alessandropalla commented Feb 23, 2024

So, just ran locally tests/models/[gemma,llama]/test_modeling_[gemma,llama].py and got a bunch of errors that I'm not sure are related to the PR but most probably from my environment

FAILED tests/models/gemma/test_modeling_gemma.py::GemmaModelTest::test_cpu_offload - AssertionError: Items in the second set but not the first:
FAILED tests/models/gemma/test_modeling_gemma.py::GemmaModelTest::test_disk_offload_bin - ValueError: You are trying to offload the whole model to the disk. Please use the `disk_offload` function instead.
FAILED tests/models/gemma/test_modeling_gemma.py::GemmaModelTest::test_disk_offload_safetensors - ValueError: You are trying to offload the whole model to the disk. Please use the `disk_offload` function instead.
FAILED tests/models/gemma/test_modeling_gemma.py::GemmaModelTest::test_model_parallelism - AssertionError: Items in the second set but not the first:

FAILED tests/models/llama/test_modeling_llama.py::LlamaModelTest::test_cpu_offload - AssertionError: Items in the second set but not the first:
FAILED tests/models/llama/test_modeling_llama.py::LlamaModelTest::test_disk_offload_bin - ValueError: You are trying to offload the whole model to the disk. Please use the `disk_offload` function instead.
FAILED tests/models/llama/test_modeling_llama.py::LlamaModelTest::test_disk_offload_safetensors - ValueError: You are trying to offload the whole model to the disk. Please use the `disk_offload` function instead.
FAILED tests/models/llama/test_modeling_llama.py::LlamaModelTest::test_model_parallelism - AssertionError: Items in the second set but not the first:

In my env, set(new_model.hf_device_map.values()) returns only {cpu}, also the other error seems to be device_map related

@ArthurZucker
Copy link
Collaborator

Yes those are unrelated!

@ArthurZucker ArthurZucker merged commit 3f60d11 into huggingface:main Feb 23, 2024
19 checks passed
@ArthurZucker
Copy link
Collaborator

Thanks for the PR 🤗

ArthurZucker pushed a commit that referenced this pull request Feb 28, 2024
ArthurZucker pushed a commit that referenced this pull request Mar 1, 2024
itazap pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants