Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for metadata format MLX #29335

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

alexweberk
Copy link
Contributor

Add support for loading safetensors files saved with metadata format mlx.

Fixes #29333

Add support for loading safetensors files saved with metadata format mlx.
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@LysandreJik LysandreJik merged commit 45c0651 into huggingface:main Mar 7, 2024
20 of 21 checks passed
@pcuenca
Copy link
Member

pcuenca commented Mar 7, 2024

This doesn't work in my tests when loading using from_pretrained. It raises here:

In addition, it requires mlx to be installed, which should not be necessary, as described in #29511 (sorry, I did not see this PR when I created mine).

damithsenanayake pushed a commit to damithsenanayake/transformers that referenced this pull request Mar 7, 2024
Add support for loading safetensors files saved with metadata format mlx.
@alexweberk alexweberk deleted the patch-1 branch March 22, 2024 00:38
itazap pushed a commit that referenced this pull request May 14, 2024
Add support for loading safetensors files saved with metadata format mlx.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for models trained using MLX
4 participants