Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torch_empty_cache_steps to TrainingArguments #31546

Merged
merged 8 commits into from
Jul 4, 2024

Conversation

aliencaocao
Copy link
Contributor

@aliencaocao aliencaocao commented Jun 22, 2024

What does this PR do?

Following up on #31530, add torch.cuda.empty_cache() as an optional TrainingArgument to the training loop every N step, such that those who need it to avoid OOMs can use it.

Also added to the reduce vram usage docs and changed the table for mixed precision training a bit - let me know if you prefer this change to be isolated in another PR.

Not sure if a test is needed - we can't really 'verify' it being called besides monitoring vram usage?

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@muellerz @amyeroberts

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Overall I think this looks OK, but let's get @muellerzr's opinion

src/transformers/training_args.py Outdated Show resolved Hide resolved
Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, overall this looks good to me, bar one nit for our docs!

src/transformers/training_args.py Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for adding!

@muellerzr
Copy link
Contributor

Test failures look unrelated, so we're okay to merge here I think.

src/transformers/trainer.py Outdated Show resolved Hide resolved
Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thanks!

@muellerzr muellerzr merged commit 43ffb78 into huggingface:main Jul 4, 2024
21 checks passed
@aliencaocao aliencaocao deleted the empty-cache-arg branch July 4, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants