-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add torch_empty_cache_steps to TrainingArguments #31546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
Overall I think this looks OK, but let's get @muellerzr's opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, overall this looks good to me, bar one nit for our docs!
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks for adding!
Test failures look unrelated, so we're okay to merge here I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Thanks!
What does this PR do?
Following up on #31530, add
torch.cuda.empty_cache()
as an optionalTrainingArgument
to the training loop every N step, such that those who need it to avoid OOMs can use it.Also added to the reduce vram usage docs and changed the table for mixed precision training a bit - let me know if you prefer this change to be isolated in another PR.
Not sure if a test is needed - we can't really 'verify' it being called besides monitoring vram usage?
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerz @amyeroberts