Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_errors=True to trainer.py rmtree in _inner_training_loop #31668

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Add ignore_errors=True to trainer.py rmtree in _inner_training_loop #31668

merged 1 commit into from
Jul 3, 2024

Conversation

njbrake
Copy link
Contributor

@njbrake njbrake commented Jun 27, 2024

What does this PR do?

Fixes #17265

ignore_errors was already put into on rmtree call via #20984, but appears to have missed the call that happens in the _inner_training_loop

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x ] Did you read the contributor guideline,
    Pull Request section?
  • [ x] Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Adding
@amyeroberts @sgugger since they had been corresponding on the linked issue

@njbrake njbrake changed the title Add ignore_errors=True Add ignore_errors=True to trainer.py rmtree in _inner_training_loop Jun 27, 2024
Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR!

@muellerzr muellerzr merged commit 65a02cd into huggingface:main Jul 3, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSError Directory not empty error in Trainer.py on checkpoint replacement
4 participants