Fix Gemma2 4d attention mask #31674
Merged
Fix Gemma2 4d attention mask #31674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyouga
added a commit
to hiyouga/LLaMA-Factory
that referenced
this pull request
Jun 27, 2024
Gemma2 finetuning cannot work until merging huggingface/transformers#31674
ArthurZucker
approved these changes
Jun 28, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
added a commit
that referenced
this pull request
Jun 28, 2024
Update modeling_gemma2.py Co-authored-by: Arthur <[email protected]>
|
The patch is out for this! Thanks again 🤗 https://pypi.org/project/transformers/4.42.2/ |
PrimaLuz
pushed a commit
to PrimaLuz/LLaMA-Factory
that referenced
this pull request
Jul 1, 2024
Gemma2 finetuning cannot work until merging huggingface/transformers#31674
|
Thank you all for your hard work. I've been dealing with this issue recently as well. |
xtchen96
pushed a commit
to xtchen96/LLaMA-Factory
that referenced
this pull request
Jul 17, 2024
Gemma2 finetuning cannot work until merging huggingface/transformers#31674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Might) continuation of #31670
Fixes #31673
The attention mask here should be a 4d mask, while the current implementation mistakenly treated it as a 2d mask. Additionally, the mask needs to be inverted to prevent label leakage.
Before this pr:
After this pr:
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker