Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate vocab_size in other two VLMs #31681

Merged

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

Continuing on #31655, let's deprecate the model.config.vocab_size for all VLMs for consistency across repo and use model.config.text_config.vocab_size in future models.

Currently only Fuyu and Paligemma have vocab_size in config file, and I depreacted it to v4.43. Or should it be v4.44?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - thanks for handling!

src/transformers/models/fuyu/configuration_fuyu.py Outdated Show resolved Hide resolved
@prakash-shubham-2003
Copy link

@zucchini-nlp @amyeroberts
After this update, I am facing an error while making an instance of LlavaProcessor. This is the code I wrote:
'processor = AutoProcessor.from_pretrained("llava-hf/llava-1.5-7b-hf")'

It gives the following error:
'TypeError: LlavaProcessor.init() got an unexpected keyword argument 'chat_template''

It was working fine before the update. I have the following versions of transformers and bitsandbytes installed:
'!pip install -q -U transformers==4.37.2'
'!pip install -q bitsandbytes==0.41.3 accelerate==0.25.0'

Is there any issue with the current update or is there any other solution for this problem?

@zucchini-nlp
Copy link
Member Author

zucchini-nlp commented Jun 28, 2024

Answered the question in another thread, not related to this PR. Please open an issue if you still encounter the error after updating transformers :)

@zucchini-nlp zucchini-nlp merged commit 952dfd4 into huggingface:main Jul 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants