Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wav2Vec2 Fairseq conversion (weight norm state dict keys) #31714

Merged

Conversation

gau-nernst
Copy link
Contributor

What does this PR do?

Close #31633

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@sanchit-gandhi @amyeroberts

To test

wget https://dl.fbaipublicfiles.com/fairseq/wav2vec/wav2vec_small.pt  # wav2vec2-base checkpoint from facebook
pip install git+https://github.com/facebookresearch/fairseq.git  # install fairseq

python src/transformers/models/wav2vec2/convert_wav2vec2_original_pytorch_checkpoint_to_pytorch.py \
    --pytorch_dump_folder wav2vec2-base \
    --checkpoint_path wav2vec_small.pt \
    --config_path facebook/wav2vec2-base \
    --not_finetuned

I only checked for Wav2Vec2 base. Other checkpoints should work too. See other checkpoints from fairseq here: https://github.com/facebookresearch/fairseq/tree/main/examples/wav2vec

e.g. https://dl.fbaipublicfiles.com/fairseq/wav2vec/libri960_big.pt corresponds to https://huggingface.co/facebook/wav2vec2-large

@amyeroberts
Copy link
Collaborator

cc @kamilakesbi

@gau-nernst
Copy link
Contributor Author

gentle ping @amyeroberts @kamilakesbi

Copy link
Contributor

@kamilakesbi kamilakesbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gau-nernst, thanks for working on this!

It LGTM! failing tests seem to be unrelated to this PR.

cc @amyeroberts for final review :)

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@amyeroberts amyeroberts merged commit a8fa6fb into huggingface:main Jul 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert_wav2vec2_original_pytorch_checkpoint_to_pytorch.py does not work due to weight norm key
3 participants