Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tensor device correct when ACCELERATE_TORCH_DEVICE is defined #31751

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

kiszk
Copy link
Contributor

@kiszk kiszk commented Jul 2, 2024

What does this PR do?

Fixes #31750

This PR fixes the issue of returning an incorrect device (cpu) of tensors passed to a model with accelerate when ACCELERATE_TORCH_DEVICE is defined as privateuseone:0. When known accelerators are not available, a function should check whether ACCELERATE_TORCH_DEVICE is defined or not before returning cpu.

It looks hard to write a test problem with privateuseone:0. I manually tested the issue was fixed with this PR. Any idea to add tests are appreciated.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@muellerzr @SunMarc

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Just want to double check with @muellerzr before merge this is correct

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense to me as we do similar in Accelerate in the end :)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kiszk!

@LysandreJik LysandreJik merged commit 2aa2a14 into huggingface:main Jul 5, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tensors' device passed to a model is not correct when ACCELERATE_TORCH_DEVICE is privateuseone
5 participants