Make tensor device correct when ACCELERATE_TORCH_DEVICE is defined #31751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #31750
This PR fixes the issue of returning an incorrect device (
cpu
) of tensors passed to a model withaccelerate
whenACCELERATE_TORCH_DEVICE
is defined asprivateuseone:0
. When known accelerators are not available, a function should check whetherACCELERATE_TORCH_DEVICE
is defined or not before returningcpu
.It looks hard to write a test problem with
privateuseone:0
. I manually tested the issue was fixed with this PR. Any idea to add tests are appreciated.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerzr @SunMarc