Fix gemma tests #31794
Merged
Fix gemma tests #31794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Jul 4, 2024
Comment on lines
+610
to
+611
| "Hello I am doing a project on the 1990s and I need to know what the most popular music", | ||
| "Hi today I am going to share with you a very easy and simple recipe of <strong><em>Khichdi", |
There was a problem hiding this comment.
This is in def test_model_2b_eager(self): which is always failing (previously token issue and assertion failed after a fix for it)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
commented
Jul 4, 2024
| @@ -815,7 +824,7 @@ def test_model_7b_4bit(self): | |||
| EXPECTED_TEXTS = { | |||
| 7: [ | |||
| "Hello I am doing a project for my school and I am trying to make a program that will take a number and then", | |||
| """Hi today I am going to talk about the new update for the game called "The new update" and I""", | |||
| "Hi today I am going to talk about the best way to get rid of acne. miniaturing is a very", | |||
There was a problem hiding this comment.
test_model_7b_4bit starts to fail since April 24. I still get failures when I checkout to commits before that date. Likely some changes in the bnb. Let's just update.
There was a problem hiding this comment.
(well, it probably fails even in earlier date as we switch slack report channels a few month back and I only check one channel that is currently used)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
gemma-7btests: it's just OOM (even run each single one test)google/gemma-2-9bused intest_model_2b_fp16(it also gives OOM)test_model_2b_eagerandtest_model_7b_4bit. See comment in the change