Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect accelerator device handling for MPS in TrainingArguments #31812

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Fix incorrect accelerator device handling for MPS in TrainingArguments #31812

merged 4 commits into from
Jul 8, 2024

Conversation

andstor
Copy link
Contributor

@andstor andstor commented Jul 5, 2024 •
edited
Loading

This PR fixes incorrect accelerator device handling for MPS in TrainingArguments.

Fixes #31811

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@muellerzr @SunMarc

amyeroberts
amyeroberts approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

SunMarc
SunMarc approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Thanks for fixing @andstor !

@amyeroberts amyeroberts merged commit ae9dd02 into huggingface:main Jul 8, 2024
20 checks passed
@jponf jponf mentioned this pull request Jul 21, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunMarc SunMarc SunMarc approved these changes

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect accelerator device handling for MPS in TrainingArguments
3 participants
@andstor @amyeroberts @SunMarc