Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix _init_weights for ResNetPreTrainedModel" #31868

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jul 9, 2024

Reverts #31851

More failures when merged into main. I probably made a mistake and didn't trigger a full run on t his PR. Sorry

@ydshieh ydshieh requested a review from amyeroberts July 9, 2024 18:43
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on the fix!

@ydshieh ydshieh merged commit b45dd5d into main Jul 9, 2024
22 checks passed
@ydshieh ydshieh deleted the revert-31851-fix_init_resnet branch July 9, 2024 21:00
ydshieh added a commit that referenced this pull request Jul 10, 2024
ydshieh added a commit that referenced this pull request Jul 10, 2024
* Revert "Revert "Fix `_init_weights` for `ResNetPreTrainedModel`" (#31868)"

This reverts commit b45dd5d.

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

---------

Co-authored-by: ydshieh <[email protected]>
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Jul 19, 2024
* Revert "Revert "Fix `_init_weights` for `ResNetPreTrainedModel`" (huggingface#31868)"

This reverts commit b45dd5d.

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

---------

Co-authored-by: ydshieh <[email protected]>
MHRDYN7 pushed a commit to MHRDYN7/transformers that referenced this pull request Jul 23, 2024
* Revert "Revert "Fix `_init_weights` for `ResNetPreTrainedModel`" (huggingface#31868)"

This reverts commit b45dd5d.

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

---------

Co-authored-by: ydshieh <[email protected]>
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jul 24, 2024
* Revert "Revert "Fix `_init_weights` for `ResNetPreTrainedModel`" (huggingface#31868)"

This reverts commit b45dd5d.

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

* fix

* [test_all] check

---------

Co-authored-by: ydshieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants