Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable xla fsdp #32048

Merged
merged 3 commits into from
Aug 7, 2024
Merged

enable xla fsdp #32048

merged 3 commits into from
Aug 7, 2024

Conversation

hanwen-sun
Copy link
Contributor

What does this PR do?

We have supported xla fsdp in accelerator, so we should enable xla fsdp in transformers.
the support of xla fsdp in accelerate: huggingface/accelerate#2176 and huggingface/accelerate#2941

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@amyeroberts
Copy link
Collaborator

cc @muellerzr @SunMarc

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated for the enable!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can do this directly. AFAICT this was enabled in 0.28 but the required version in our setup.py for accelerate is 0.21. Instead we'll need to add a condition checking the accelerate version is >= 0.28

@hanwen-sun
Copy link
Contributor Author

I don't think we can do this directly. AFAICT this was enabled in 0.28 but the required version in our setup.py for accelerate is 0.21. Instead we'll need to add a condition checking the accelerate version is >= 0.28

So I need to add a condition checking that accelerate version is >= 0.28?

@amyeroberts
Copy link
Collaborator

@hanwen-sun Yes - you should add is_accelerate_available("0.28.0") to the if statement

@hanwen-sun
Copy link
Contributor Author

@hanwen-sun Yes - you should add is_accelerate_available("0.28.0") to the if statement

thank you, I have updated.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts amyeroberts merged commit 46d09af into huggingface:main Aug 7, 2024
21 checks passed
@steveepreston
Copy link
Contributor

Created #34197 to revert this change due to #34176 issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants