Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated fsdp.md to Korean #32261

Merged
merged 8 commits into from
Aug 8, 2024

Conversation

win2dvp21
Copy link
Contributor

@win2dvp21 win2dvp21 commented Jul 27, 2024

What does this PR do?

Translated the fsdp.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

May you please review this PR?

@win2dvp21, @enchantee00, @fabxoe, @1kmmk1, @junejae

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?

docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
Copy link
Contributor

@junejae junejae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세심한 번역 감사드립니다! 용어만 조금 다듬으면 될 것 같아요!

docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
Co-authored-by: 김준재 <[email protected]>
Co-authored-by: Minki Kim <[email protected]>
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
@win2dvp21 win2dvp21 marked this pull request as ready for review August 6, 2024 10:19
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your translation 🤗

docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
docs/source/ko/fsdp.md Outdated Show resolved Hide resolved
@stevhliu stevhliu merged commit 496207a into huggingface:main Aug 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants