Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated awq.mdto Korean #32324

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Conversation

ahnjj
Copy link
Contributor

@ahnjj ahnjj commented Jul 30, 2024

What does this PR do?

Translated the awq.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@mjk0618, @cjfghk5697, @ahnjj, @JinukHong, @nuatmochoi

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?

@ahnjj ahnjj marked this pull request as ready for review July 30, 2024 14:07
@ahnjj ahnjj marked this pull request as draft July 31, 2024 01:29
@ahnjj ahnjj marked this pull request as ready for review July 31, 2024 01:34
@ahnjj ahnjj marked this pull request as draft July 31, 2024 01:34
Copy link
Contributor

@cjfghk5697 cjfghk5697 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한번 간단하게 glossary에 맞추고 수정해봤습니다..!

docs/source/ko/tasks/awq.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/awq.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/awq.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/awq.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/awq.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/awq.md Outdated Show resolved Hide resolved
ahnjj and others added 3 commits August 7, 2024 10:01
Co-authored-by: SeongWooChoi <[email protected]>
Co-authored-by: Chulhwa (Evan) Han <[email protected]>
- 잘못된 경로에 번역본 파일을 생성해서 옮김
@ahnjj ahnjj marked this pull request as ready for review August 7, 2024 04:18
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks for your contribution! Once we fix the toctree, we should be ready to merge 🤗

docs/source/ko/_toctree.yml Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit 7f777ab into huggingface:main Aug 12, 2024
8 checks passed
stevhliu added a commit to stevhliu/transformers that referenced this pull request Aug 21, 2024
* fix: manual edits

* Apply suggestions from code review

Co-authored-by: SeongWooChoi <[email protected]>
Co-authored-by: Chulhwa (Evan) Han <[email protected]>

* fix:manual edits

- 잘못된 경로에 번역본 파일을 생성해서 옮김

* Delete docs/source/ko/tasks/awq.md

* Update docs/source/ko/_toctree.yml

Co-authored-by: Steven Liu <[email protected]>

---------

Co-authored-by: SeongWooChoi <[email protected]>
Co-authored-by: Chulhwa (Evan) Han <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants