Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fixes to properly shard FSDP across cpu and meta for cpu_effcient_loading for prequantized 4bit (#32276)" #32477

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

matthewdouglas
Copy link
Member

What does this PR do?

This reverts commit 62c60a3 (PR #32276)

We uncovered an issue with this change that caused our training runs to hang. It works with the PR reverted. I'll create a separate issue to continue work on addressing the CPU memory usage with FSDP.

See internal discussion

Trainable params: 627,572,736 || all params: 410,708,819,968 || trainable%: 0.1528
[rank0]:[E ProcessGroupNCCL.cpp:1316] [PG 0 Rank 0] Heartbeat monitor timed out! Process will be terminated after dumping debug info. workMetaList_.size()=8
[rank0]:[E ProcessGroupNCCL.cpp:1153] [PG 0 Rank 0] ProcessGroupNCCL preparing to dump debug info.
[rank0]:[F ProcessGroupNCCL.cpp:1169] [PG 0 Rank 0] [PG 0 Rank 0] ProcessGroupNCCL's watchdog got stuck for 600 seconds without making progress in monitoring enqueued collectives. This typically indicates a NCCL/CUDA API hang blocking the watchdog, and could be triggered by another thread holding the GIL inside a CUDA api, or other deadlock-prone behaviors.If you suspect the watchdog is not actually stuck and a longer timeout would help, you can either increase the timeout (TORCH_NCCL_HEARTBEAT_TIMEOUT_SEC) to a larger value or disable the heartbeat monitor (TORCH_NCCL_ENABLE_MONITORING=0).If either of aforementioned helps, feel free to file an issue to PyTorch about the short timeout or false positive abort; otherwise, please attempt to debug the hang. workMetaList_.size() = 8
W0802 08:05:08.490000 140537132394304 torch/distributed/elastic/multiprocessing/api.py:851] Sending process 1038311 closing signal SIGTERM
W0802 08:05:08.495000 140537132394304 torch/distributed/elastic/multiprocessing/api.py:851] Sending process 1038312 closing signal SIGTERM
W0802 08:05:08.496000 140537132394304 torch/distributed/elastic/multiprocessing/api.py:851] Sending process 1038313 closing signal SIGTERM
W0802 08:05:08.496000 140537132394304 torch/distributed/elastic/multiprocessing/api.py:851] Sending process 1038314 closing signal SIGTERM
W0802 08:05:08.496000 140537132394304 torch/distributed/elastic/multiprocessing/api.py:851] Sending process 1038315 closing signal SIGTERM
W0802 08:05:08.497000 140537132394304 torch/distributed/elastic/multiprocessing/api.py:851] Sending process 1038316 closing signal SIGTERM
W0802 08:05:08.498000 140537132394304 torch/distributed/elastic/multiprocessing/api.py:851] Sending process 1038317 closing signal SIGTERM
E0802 08:05:09.741000 140537132394304 torch/distributed/elastic/multiprocessing/api.py:826] failed (exitcode: -6) local_rank: 0 (pid: 1038310)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker @muellerzr

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

…cient_loading for prequantized 4bit (#32276)"

This reverts commit 62c60a3.

We uncovered an issue with this change that caused our training runs to hang.
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, cc @winglian I can patch if you find a solution later on!

* cast a wide net

* make fix-copies with a few manual changes

* add copied from
Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch!

@ArthurZucker ArthurZucker merged commit ac2707e into main Aug 6, 2024
24 checks passed
@ArthurZucker ArthurZucker deleted the revert-fsdp-sharding-fix branch August 6, 2024 18:29
ArthurZucker pushed a commit that referenced this pull request Aug 6, 2024
…ient_loading for prequantized 4bit (#32276)" (#32477)

* Revert "fixes to properly shard FSDP across cpu and meta for cpu_efficient_loading for prequantized 4bit (#32276)"

This reverts commit 62c60a3.

We uncovered an issue with this change that caused our training runs to hang.

* `is_torchdynamo_compiling` -- cast a wide exception net (#32476)

* cast a wide net

* make fix-copies with a few manual changes

* add copied from

---------

Co-authored-by: Joao Gante <[email protected]>
ArthurZucker pushed a commit that referenced this pull request Aug 6, 2024
…ient_loading for prequantized 4bit (#32276)" (#32477)

* Revert "fixes to properly shard FSDP across cpu and meta for cpu_efficient_loading for prequantized 4bit (#32276)"

This reverts commit 62c60a3.

We uncovered an issue with this change that caused our training runs to hang.

* `is_torchdynamo_compiling` -- cast a wide exception net (#32476)

* cast a wide net

* make fix-copies with a few manual changes

* add copied from

---------

Co-authored-by: Joao Gante <[email protected]>
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

nbroad1881 pushed a commit that referenced this pull request Aug 7, 2024
…ient_loading for prequantized 4bit (#32276)" (#32477)

* Revert "fixes to properly shard FSDP across cpu and meta for cpu_efficient_loading for prequantized 4bit (#32276)"

This reverts commit 62c60a3.

We uncovered an issue with this change that caused our training runs to hang.

* `is_torchdynamo_compiling` -- cast a wide exception net (#32476)

* cast a wide net

* make fix-copies with a few manual changes

* add copied from

---------

Co-authored-by: Joao Gante <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants