Fix: FA2 with packed training #32487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
reviewed
Aug 7, 2024
| # If position_ids is provided and check all examples do not contain only 1 sequence, If tensor in increasing | ||
| # then we probably have one sequence, otherwise it is packed. Additionally check we are in pre-fill/training stage. | ||
| # Use `flash_attn_varlen_func` to prevent cross-example attention and also allow padding free approach | ||
| elif position_ids is not None and not (torch.diff(position_ids) >= 0).all() and query_length != 1: |
There was a problem hiding this comment.
can we explicit that we diff on the batch dim?
There was a problem hiding this comment.
yes, will do so and add more tests!
ArthurZucker
approved these changes
Aug 8, 2024
|
Slow CI tests are failing for unrelated reasons: gated repo, OOM or failing even w/o this PR. I believe this can be merged, since many tests need to be fixed in general |
|
Yep we need to patch with this let's merge! 🤗 |
|
Yep, and #32527 for patch release plz. Can you approve it also? |
ArthurZucker
pushed a commit
that referenced
this pull request
Aug 16, 2024
* fix check * add tests * [run-slow] llama, gemma2 * oops, whisper actually runs but needed some special treatment
ArthurZucker
pushed a commit
that referenced
this pull request
Aug 20, 2024
* fix check * add tests * [run-slow] llama, gemma2 * oops, whisper actually runs but needed some special treatment
ArthurZucker
pushed a commit
that referenced
this pull request
Aug 20, 2024
* fix check * add tests * [run-slow] llama, gemma2 * oops, whisper actually runs but needed some special treatment
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Aug 21, 2024
* fix check * add tests * [run-slow] llama, gemma2 * oops, whisper actually runs but needed some special treatment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the issue from #32241 (comment). The FA2 was taking packed path when we were trying to continue with filled cache and had more than 1 new token. This could happen in assisted decoding for ex.
I think instead if checking the position ids length and last elements, we can check that if they are arranged in increasing order. We can know for sure that packed sequences will not have all elements with increasing positions. Also, we can be sure that in inference we'll always have an increasing order if there's no attn mask provided. If attn mask is there, we'll not reach this check so should not be a problem