Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed conditional check for encodec model names #32581

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

What does this PR do?

This if condition is always evaluating to True due to the second part being a non-empty string.

if model_name == "encodec_24khz" or "encodec_32khz":

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts @sanchit-gandhi

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing!

Just a small nit

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts amyeroberts merged commit bd251e4 into huggingface:main Aug 12, 2024
7 checks passed
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Aug 21, 2024
…2581)

* Fixed conditional check for encodec model names.

* Reformatted conditional check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants