Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new model #32615

Merged
merged 29 commits into from
Aug 12, 2024
Merged

Add new model #32615

merged 29 commits into from
Aug 12, 2024

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada
v1 - working version
daf5855
@younesbelkada
fix
44a4ba3
@younesbelkada
fix
46d5d89
@younesbelkada
fix
442095b
@younesbelkada
fix
3f42120
@younesbelkada
rename to correct name
1962f6b
@younesbelkada
fix title
bae0095
@younesbelkada
fixup
a9590ba
@younesbelkada
rename files
64986ca
@younesbelkada
fix
af7c86b
@younesbelkada
add copied from on tests
d732ba1
@younesbelkada
rename to FalconMamba everywhere and fix bugs
78c0e10
@younesbelkada
fix quantization + accelerate
d6fe9d3
@younesbelkada
fix copies
b22ffba
@younesbelkada
Merge remote-tracking branch 'origin/main' into add-mamba-final
65e8a2f
@younesbelkada
add torch.compile support
c7e680e
@younesbelkada
fix tests
ce89dc1
@younesbelkada
fix tests and add slow tests
4680b07
@younesbelkada
copies on config
9d124dc
@younesbelkada
Merge remote-tracking branch 'origin/main' into add-mamba-final
fcb2fb4
@younesbelkada
Merge remote-tracking branch 'origin/main' into add-mamba-final
2e72b84
@younesbelkada
merge the latest changes
a5396a5
@younesbelkada
Merge remote-tracking branch 'origin/main' into add-mamba-final
711994b
@younesbelkada
fix tests
d523216
@younesbelkada
Merge remote-tracking branch 'upstream/main' into add-mamba-final
d3ca9e1
@younesbelkada
add few lines about instruct
bc9a224
ArthurZucker
ArthurZucker approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the super clean PR

src/transformers/models/falcon_mamba/__init__.py Outdated Show resolved Hide resolved
src/transformers/models/falcon_mamba/modeling_falcon_mamba.py Outdated Show resolved Hide resolved
src/transformers/models/falcon_mamba/modeling_falcon_mamba.py Outdated Show resolved Hide resolved
src/transformers/models/falcon_mamba/modeling_falcon_mamba.py Outdated Show resolved Hide resolved
src/transformers/models/falcon_mamba/modeling_falcon_mamba.py Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker ArthurZucker merged commit 7c11491 into huggingface:main Aug 12, 2024
20 of 22 checks passed
@younesbelkada younesbelkada deleted the add-mamba-final branch August 12, 2024 06:22
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Aug 21, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
af4138e 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Aug 26, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
d0bb4bb 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Aug 26, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
6e16974 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Sep 3, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
2eda65b 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Sep 4, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
a9c7457 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Sep 9, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
7e2fb70 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Sep 16, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
2315a5c 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Sep 23, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
0356e22 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Sep 24, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
177a944 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Sep 25, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
9635f5e 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Oct 16, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
6306886 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Oct 16, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
f24eadc 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Oct 18, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
b4b02d7 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Oct 18, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
c898482 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Oct 21, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
3e16277 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Oct 22, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
b31d7a7 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Oct 23, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
d3f5f18 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Oct 24, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
cf36601 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Oct 28, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
8d5f8d7 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Oct 28, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
c60c316 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Oct 31, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
72bfedd 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Nov 6, 2024
@younesbelkada @ArthurZucker @stevhliu
Add new model (huggingface#32615)
c54e48d 
* v1 - working version

* fix

* fix

* fix

* fix

* rename to correct name

* fix title

* fixup

* rename files

* fix

* add copied from on tests

* rename to `FalconMamba` everywhere and fix bugs

* fix quantization + accelerate

* fix copies

* add `torch.compile` support

* fix tests

* fix tests and add slow tests

* copies on config

* merge the latest changes

* fix tests

* add few lines about instruct

* Apply suggestions from code review

Co-authored-by: Arthur <[email protected]>

* fix

* fix tests

---------

Co-authored-by: Arthur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@younesbelkada @HuggingFaceDocBuilderDev @ArthurZucker