Generate: unify LogitsWarper
and LogitsProcessor
#32626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
LogitsProcessor
andLogitsWarper
were originally created as two separate classes, withLogitsWarper
being aLogitsProcessor
that should only be applied to sample-based decoding methods. In practice, they are exactly the same.Having two separate classes meant that there was undesired code duplication: two functions to instantiate these objects, two separate pieces of logic to apply these processors, etc.
This PR:
LogitsWarper
and related logic, moving it to the logic related toLogitsProcessor
LogitsWarper
public with a deprecation warning, for BC