fix: (issue #32689) AttributeError
raised when using Trainer
with eval_on_start=True
in Jupyter Notebook.
#32849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #32689 (issue)
The cause of issue #32689 is that in Jupyter Notebook, for a
transformers.Trainer
, when its argumenteval_on_start
is set toTrue
, runningTrainer.train()
will lead to the following function execution order:NotebookProgressCallback.on_train_begin()
NotebookProgressCallback.on_prediction_step()
NotebookProgressCallback.on_train_end()
Running
NotebookProgressCallback.on_prediction_step()
directly afterNotebookProgressCallback.on_train_begin()
will result in two attributes ofNotebookProgressBar
, i.e.,value
andlabel
, being used before assigned (see methodsupdate()
,update_bar()
anddisplay()
ofNotebookProgressBar
in transformers/utils/notebook.py for details).A very simple solution is to initialize both attributes
value
andlabel
toNone
during the creation ofNotebookProgressBar
.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@amyeroberts @ArthurZucker
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.