Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 32299, flag users when Zero-3 was missed #32851

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

muellerzr
Copy link
Contributor

What does this PR do?

Reverts #32299 until I can come up with a better solution.

TL;DR:

  1. This broke quantization, which was attempted to fix in this PR: Fix quantization w/ DeepSpeed not working #32640
  2. However, this breaks Zero-3 inference plainly, so for now disabled while leaving context in the test.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker

@muellerzr muellerzr changed the title Revert PR 32299 Revert PR 32299, flag users when Zero-3 was missed Aug 16, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reverting!

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DId any of our CI fail ? You linked a PR but not issue so wondering if we are properly testing? 🤗

@muellerzr
Copy link
Contributor Author

None that I can tell, but our DS CI needs work to actually make the error logs readable. I'll see what I can do.

@muellerzr muellerzr merged commit 0b066be into main Aug 16, 2024
24 checks passed
@muellerzr muellerzr deleted the muellerzr-fix-ds-not-working branch August 16, 2024 16:35
ArthurZucker pushed a commit that referenced this pull request Aug 16, 2024
ArthurZucker pushed a commit that referenced this pull request Aug 20, 2024
ArthurZucker pushed a commit that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants