Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chat_template for tokenizer extracted from GGUF model #32908

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Add chat_template for tokenizer extracted from GGUF model #32908

merged 3 commits into from
Aug 22, 2024

Conversation

Isotr0py
Copy link
Contributor

@Isotr0py Isotr0py commented Aug 21, 2024 •
edited
Loading

What does this PR do?

  • Currently, tokenizer extracted from GGUF model misses a chat_template.
  • This PR adds missing chat_template through minor fix when extract tokenizer from GGUF model file

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

SunMarc
SunMarc reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding ! Just a nit

src/transformers/integrations/ggml.py Outdated Show resolved Hide resolved
@Isotr0py Isotr0py requested a review from SunMarc August 22, 2024 14:05
SunMarc
SunMarc approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for adding this !

@ArthurZucker
Copy link
Collaborator

Thanks!

@ArthurZucker ArthurZucker merged commit ee8c01f into huggingface:main Aug 22, 2024
21 checks passed
@Isotr0py Isotr0py deleted the gguf-template branch August 22, 2024 14:42
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Isotr0py Isotr0py mentioned this pull request Aug 29, 2024
Closed
1 task
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Aug 30, 2024
@Isotr0py @zucchini-nlp
Add chat_template for tokenizer extracted from GGUF model (huggingfac…
fbb6d51 
…e#32908)

* add chat_template to gguf tokenizer

* add template through tokenizer config
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Aug 30, 2024
@Isotr0py @zucchini-nlp
Add chat_template for tokenizer extracted from GGUF model (huggingfac…
043bbf8 
…e#32908)

* add chat_template to gguf tokenizer

* add template through tokenizer config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

@SunMarc SunMarc SunMarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Isotr0py @ArthurZucker @HuggingFaceDocBuilderDev @SunMarc