DeviceGuard added to use Deformable Attention more safely on multi-GPU #32910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tr.py Co-authored-by: amyeroberts <[email protected]>
DonggeunYu
changed the title
amyeroberts
approved these changes
Aug 22, 2024
|
@DonggeunYu We had an issue with our test runners. Could you push an empty commit to trigger a re-run and make everything green? |
It has been completed! |
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Aug 30, 2024
huggingface#32910) * Update modeling_deformable_detr.py * Update src/transformers/models/deformable_detr/modeling_deformable_detr.py Co-authored-by: amyeroberts <[email protected]> * Update ms_deform_attn_cuda.cu * Update modeling_deformable_detr.py * Update modeling_deformable_detr.py * [empty] this is a empty commit --------- Co-authored-by: amyeroberts <[email protected]>
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Aug 30, 2024
huggingface#32910) * Update modeling_deformable_detr.py * Update src/transformers/models/deformable_detr/modeling_deformable_detr.py Co-authored-by: amyeroberts <[email protected]> * Update ms_deform_attn_cuda.cu * Update modeling_deformable_detr.py * Update modeling_deformable_detr.py * [empty] this is a empty commit --------- Co-authored-by: amyeroberts <[email protected]>
itazap
pushed a commit
to NielsRogge/transformers
that referenced
this pull request
Sep 20, 2024
huggingface#32910) * Update modeling_deformable_detr.py * Update src/transformers/models/deformable_detr/modeling_deformable_detr.py Co-authored-by: amyeroberts <[email protected]> * Update ms_deform_attn_cuda.cu * Update modeling_deformable_detr.py * Update modeling_deformable_detr.py * [empty] this is a empty commit --------- Co-authored-by: amyeroberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I got zero results from deformable attention when multi-GPU inference.
However, this issue happens only in my environment.
The DeviceGuard has been added to ensure that calculations are performed only on the value device. Thus, my problem has been resolved.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Models: