Add warning and info message for beta and gamma parameters #33192
Conversation
add warn and info message when load "gamma" and "beta" keys in _load_pretrained_model
without other changes
|
cc @amyeroberts |
There was a problem hiding this comment.
Thanks for adding this @zly-idleness!
At the moment, this involves iterating over the loaded keys twice - once on L4116 and then on L4146. It also involves a redefinition of original_loaded_keys. We should rework the code to reduce the double logic
Thank you for pointing that out. I'll refactor the code to eliminate redundancy |
| old_keys.append(key) | ||
| new_keys.append(new_key) | ||
| renamed_keys[key] = new_key | ||
| loaded_keys[i] = new_key |
There was a problem hiding this comment.
This doesn't work - this will modify both loaded_keys and original_loaded_keys:
In [1]: li_0 = list(range(10))
In [2]: li_1 = li_0
In [3]: for i in range(10):
...: if i % 2:
...: li_0[i] = -1
...:
In [4]: li_0
Out[4]: [0, -1, 2, -1, 4, -1, 6, -1, 8, -1]
In [5]: li_1
Out[5]: [0, -1, 2, -1, 4, -1, 6, -1, 8, -1]There was a problem hiding this comment.
Thank you sir ! You are totally right , I forget add a copy() to ensure that the original_loaded_keys remain unaltered.
There was a problem hiding this comment.
There shouldn't be any changes to this file in the PR
| warning_msg += 'contains parameters that have been renamed internally ("gamma" and "beta" in parameters) (a few are listed below but more are present in the model):\n' | ||
| logger.warning(warning_msg) | ||
| for old_key, new_key in renamed_keys.items(): | ||
| warning_msg += f"* `{old_key}` -> `{new_key}`\n" | ||
| warning_msg += "If you are using a model from the Hub, consider submitting a PR to adjust these weights and help future users." | ||
| logger.info(warning_msg) |
There was a problem hiding this comment.
This message isn't consistent - at the moment all of the renamed keys will be listed. Like in the other places where this logic is added, let's just take the first renames
| return None | ||
|
|
||
| for i, key in enumerate(loaded_keys): | ||
| new_key = _fix_key(key) |
There was a problem hiding this comment.
Rather than try and use the existing _fix_key logic - it would be better to rework this to:
- Not use
copy - To only add the first renaming case for gamma and beta respectively
What does this PR do?
This adds a warning message to notify about the renaming of gamma and beta parameters during initialisation and also during loading.
before:
after:
Fixes #29554 and #33190 (issue)
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.