-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDPA support for M2M100 #33309
Add SDPA support for M2M100 #33309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding!
Changes look good to me.
Final step before merge is running the slow tests for the models. Could you push an empty commit with the message [run_slow] m2m_100, nllb
?
slow runs cc @amyeroberts |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Great - all looks good. @isaac091 could you resolve the conflicts? Once done we should be good to merge |
Resolved! Thanks @amyeroberts. |
Merging as the failing hub tests are unrelated (also on other PRs, shouldn't be impacted by this PR, looks like connection errors) and slow tests all pass (other than multi-gpu test which also failed for a connection error) |
* Add SDPA support for M2M100 * [run_slow] m2m_100, nllb
What does this PR do?
This PR adds SDPA support for M2M100 models.
Part of #28005.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @fxmarty @amyeroberts