Generate: can_generate() recursive check
#33718
Merged
+33
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
changed the title
can_generate() recursivecan_generate() recursive check
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Ok! @regisss can you comment whether this fixes the issue you encountered?
Yep it's all good on my side, the warning doesn't appear anymore with this fix. Thanks! |
ArthurZucker
approved these changes
Sep 26, 2024
Comment on lines
+1649
to
+1650
| for base in cls.__bases__: | ||
| if not hasattr(base, "can_generate"): |
There was a problem hiding this comment.
is this only grandfather check?
There was a problem hiding this comment.
it's recursive! (it calls can_generate of the parent, which in turn may call the granparent's, and so on :D )
gante
force-pushed
the
recursive_check
branch
from
24b5a46
to
9029753
Compare
ArthurZucker
pushed a commit
that referenced
this pull request
Sep 26, 2024
* add recursive check and test warnings * missing space * models without can_generate
BenjaminBossan
pushed a commit
to BenjaminBossan/transformers
that referenced
this pull request
Sep 30, 2024
* add recursive check and test warnings * missing space * models without can_generate
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Oct 2, 2024
* add recursive check and test warnings * missing space * models without can_generate
dataKim1201
pushed a commit
to dataKim1201/transformers
that referenced
this pull request
Oct 7, 2024
* add recursive check and test warnings * missing space * models without can_generate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The deprecation warning added in #33203 was incomplete: classes inheriting from classes that have received the update were throwing the warning. This PR adds a recursive check to
can_generate()and tests the warnings thrown by the function.Example of script that is throwing a warning, but shouldn't (and is fixed in this PR):
Thank you @regisss for warning me about this one and providing a reproducer 🙏