Quick cleanup #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieu-benoit
commented
Oct 6, 2023
| @@ -38,19 +38,17 @@ This reference architecture implementation uses Terraform. You will need to do t | |||
|
|
|||
| 3. Ensure you are logged in with `gcloud` (See: [gcloud auth application-default login](https://cloud.google.com/sdk/gcloud/reference/auth/application-default)). | |||
|
|
|||
| You will need to ensure your Google Cloud account has appropriate permissions on the project you wish to provision in (see [Required Google Cloud Permissions](#required-google-cloud-permissions)). | |||
There was a problem hiding this comment.
No dedicated section, so removing it?
mathieu-benoit
commented
Oct 6, 2023
|
|
||
| 4. Ensure the [Kubernetes Engine API](https://console.cloud.google.com/marketplace/product/google/container.googleapis.com) is enabled for your project. |
There was a problem hiding this comment.
Now in Terraform: modules.base.main.tf
mathieu-benoit
commented
Oct 6, 2023
| @@ -28,13 +28,7 @@ resource "google_project_iam_member" "gke_admin" { | |||
| member = "serviceAccount:${google_service_account.gke_cluster_access.email}" | |||
| } | |||
|
|
|||
| resource "google_project_iam_member" "gke_logging_viewer" { | |||
There was a problem hiding this comment.
Not needed because using logging-k8s
mathieu-benoit
commented
Oct 6, 2023
| @@ -9,9 +9,9 @@ terraform { | |||
| helm = { | |||
| source = "hashicorp/helm" | |||
| } | |||
| http = { | |||
There was a problem hiding this comment.
Not used by default, so let's comment to avoid terraform init to resolve/download it?
|
Ready for your review, thanks! |
johanneswuerbach
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.